gengliangwang commented on code in PR #52764:
URL: https://github.com/apache/spark/pull/52764#discussion_r2529344439
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -285,11 +286,14 @@ object Analyzer {
* Provides a logical query plan analyzer, which translates
[[UnresolvedAttribute]]s and
* [[UnresolvedRelation]]s into fully typed objects using information in a
[[SessionCatalog]].
*/
-class Analyzer(override val catalogManager: CatalogManager) extends
RuleExecutor[LogicalPlan]
+class Analyzer(
+ override val catalogManager: CatalogManager,
+ val sharedRelationCache: SharedRelationCache = SharedRelationCache.empty)
Review Comment:
It seems that we have to change multiple constructors. Do we consider making
`sharedRelationCache` part of `CatalogManager`?
This is open question. It is not exactly what `CatalogManager` supporsed to
include though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
