aokolnychyi commented on code in PR #52764:
URL: https://github.com/apache/spark/pull/52764#discussion_r2543683616
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -365,6 +368,41 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
}
}
+ private[sql] def lookupCachedTable(
Review Comment:
@gengliangwang, I tested the rename locally, but not sure it would make the
code any clearer. In fact, it only creates inconsistencies with other methods
that accept name in args but don't have `xxxByName` suffix.
I feel `lookupCachedTable(name, resolver)` is already pretty clear. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
