aokolnychyi commented on code in PR #52764:
URL: https://github.com/apache/spark/pull/52764#discussion_r2529505531
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -285,11 +286,14 @@ object Analyzer {
* Provides a logical query plan analyzer, which translates
[[UnresolvedAttribute]]s and
* [[UnresolvedRelation]]s into fully typed objects using information in a
[[SessionCatalog]].
*/
-class Analyzer(override val catalogManager: CatalogManager) extends
RuleExecutor[LogicalPlan]
+class Analyzer(
+ override val catalogManager: CatalogManager,
+ val sharedRelationCache: SharedRelationCache = SharedRelationCache.empty)
Review Comment:
Unfortunately, `CacheManager` and `CatalogManager` are two very different
concepts and actually live in separate modules (catalyst and sql). It is going
to be very hard to access `CacheManager` in the analyzer.
That said, I am open to any ideas on how to simplify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
