viirya commented on PR #52578: URL: https://github.com/apache/spark/pull/52578#issuecomment-3600960206
>> 1. The mix-in trait should override ScanBuilder rather than Scan for consistency. > I am neutral on this. I can make a change to do this if all are agreed on this direction. For the refactor, I opened https://github.com/apache/spark/pull/53276. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
