vinodkc commented on code in PR #53275:
URL: https://github.com/apache/spark/pull/53275#discussion_r2582883073
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala:
##########
@@ -77,7 +86,7 @@ object SparkConnectServerUtils {
command += "--jars" += catalystTestJar
command += "--conf" += s"spark.connect.grpc.binding.port=$port"
command ++= testConfigs
- command ++= debugConfigs
Review Comment:
>where do we define debugConfigs?
`debugConfigs` is defined in
[IntegrationTestUtils](https://github.com/apache/spark/blob/master/sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/IntegrationTestUtils.scala#L62)
,
>can we remove it now?
`debugConfigs` may be required for other other/future Testsuites, so I
didn't remove it.
`log4jConfigs` is same as `debugConfigs` , except `if (isDebug)` condition.
To support both debug and non debug test modes , if (isDebug) is not
required .
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala:
##########
@@ -77,7 +86,7 @@ object SparkConnectServerUtils {
command += "--jars" += catalystTestJar
command += "--conf" += s"spark.connect.grpc.binding.port=$port"
command ++= testConfigs
- command ++= debugConfigs
Review Comment:
>where do we define debugConfigs?
`debugConfigs` is defined in
[IntegrationTestUtils](https://github.com/apache/spark/blob/master/sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/IntegrationTestUtils.scala#L62)
,
>can we remove it now?
`debugConfigs` may be required for other/future Testsuites, so I didn't
remove it.
`log4jConfigs` is same as `debugConfigs` , except `if (isDebug)` condition.
To support both debug and non debug test modes , if (isDebug) is not
required .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
