pan3793 commented on code in PR #53275:
URL: https://github.com/apache/spark/pull/53275#discussion_r2579701267
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala:
##########
@@ -93,21 +94,47 @@ object SparkConnectServerUtils {
if (isDebug) {
builder.redirectError(Redirect.INHERIT)
builder.redirectOutput(Redirect.INHERIT)
- } else {
- // If output is not consumed, the stdout/stderr pipe buffers will fill
up,
- // causing the server process to block on write() calls
- builder.redirectError(Redirect.DISCARD)
- builder.redirectOutput(Redirect.DISCARD)
}
val process = builder.start()
consoleOut = process.getOutputStream
+ if (!isDebug) {
+ // Redirect stdout and stderr to log files.
+ // If output is not consumed, the stdout/stderr pipe buffers will fill
up,
+ // causing the server process to block on write() calls.
+ val targetDir = new File(s"$connectClientHomeDir/target")
+ targetDir.mkdirs()
+ val timestamp = System.currentTimeMillis()
+ val stdoutLogFile = new File(targetDir,
s"spark-connect-test-server-stdout-$timestamp.log")
+ val stderrLogFile = new File(targetDir,
s"spark-connect-test-server-stderr-$timestamp.log")
Review Comment:
thanks for the detailed explanation, let's continue the discussion at
https://github.com/apache/spark/pull/53275#discussion_r2579584308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
