pan3793 commented on code in PR #53275:
URL: https://github.com/apache/spark/pull/53275#discussion_r2580227576
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala:
##########
@@ -93,21 +94,47 @@ object SparkConnectServerUtils {
if (isDebug) {
builder.redirectError(Redirect.INHERIT)
builder.redirectOutput(Redirect.INHERIT)
- } else {
- // If output is not consumed, the stdout/stderr pipe buffers will fill
up,
- // causing the server process to block on write() calls
- builder.redirectError(Redirect.DISCARD)
- builder.redirectOutput(Redirect.DISCARD)
}
val process = builder.start()
consoleOut = process.getOutputStream
+ if (!isDebug) {
Review Comment:
> Do you suggest redirecting to
./sql/connect/client/jvm/target/spark-connect-test-server-*.log on debug ON as
well?
@vinodkc, haven't seen this message when replying.
either `unit-tests.log` or `spark-connect-test-server-*.log` is fine to me,
I just think we should have a unified behavior to avoid unnecessary complexity.
BTW, for purposed new log filename, you may need to check the GHA workflow to
ensure it is caught by upload logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
