dongjoon-hyun commented on code in PR #439: URL: https://github.com/apache/spark-kubernetes-operator/pull/439#discussion_r2636886160
########## docs/config_properties.md: ########## @@ -37,6 +37,7 @@ | spark.kubernetes.operator.reconciler.retry.maxIntervalSeconds | Integer | -1 | false | Max interval(in seconds) of retries on unhandled controller errors. Set to non-positive for unlimited. | | spark.kubernetes.operator.reconciler.terminationTimeoutSeconds | Integer | 30 | false | Grace period for operator shutdown before reconciliation threads are killed. | | spark.kubernetes.operator.reconciler.trimStateTransitionHistoryEnabled | Boolean | true | true | When enabled, operator would trim state transition history when a new attempt starts, keeping previous attempt summary only. | + | spark.kubernetes.operator.reconciliationSelectors | String | | false | Comma-separated label selector(s) that the operator would be reconciling for Spark resources. If not set or set to empty string, operator would reconcile all watched Spark Apps and Clusters. | Review Comment: Can we reuse the existing namespace, `spark.kubernetes.operator.reconciler`, like this? And, `selector` might be better because we use `spark-app-selector` and `spark.kubernetes.node.selector.*` before, @jiangzho . ```scala - spark.kubernetes.operator.reconciliationSelectors + spark.kubernetes.operator.reconciler.selector ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
