jiangzho commented on code in PR #439: URL: https://github.com/apache/spark-kubernetes-operator/pull/439#discussion_r2641679659
########## docs/config_properties.md: ########## @@ -37,6 +37,7 @@ | spark.kubernetes.operator.reconciler.retry.maxIntervalSeconds | Integer | -1 | false | Max interval(in seconds) of retries on unhandled controller errors. Set to non-positive for unlimited. | | spark.kubernetes.operator.reconciler.terminationTimeoutSeconds | Integer | 30 | false | Grace period for operator shutdown before reconciliation threads are killed. | | spark.kubernetes.operator.reconciler.trimStateTransitionHistoryEnabled | Boolean | true | true | When enabled, operator would trim state transition history when a new attempt starts, keeping previous attempt summary only. | + | spark.kubernetes.operator.reconciliationSelectors | String | | false | Comma-separated label selector(s) that the operator would be reconciling for Spark resources. If not set or set to empty string, operator would reconcile all watched Spark Apps and Clusters. | Review Comment: that's a good idea! I've renamed that as `spark.kubernetes.operator.reconciler.selectors` , plural just to indicate the value can include multiple selectors ########## tests/e2e/resource-selector/chainsaw-test.yaml: ########## @@ -0,0 +1,106 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +apiVersion: chainsaw.kyverno.io/v1alpha1 +kind: Test +metadata: + name: spark-operator-resource-selector-validation +spec: + scenarios: + - bindings: + - name: APPLICATION_FILE_NAME + value: spark-example.yaml + - name: SPARK_APPLICATION_NAME + value: "spark-example-resource-selector" + - name: SPARK_VERSION + value: "4.1.0" + - name: JAVA_VERSION + value: "17" + - name: IMAGE + value: "apache/spark:4.1.0-scala-java17" Review Comment: updated, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
