jiangzho commented on code in PR #439: URL: https://github.com/apache/spark-kubernetes-operator/pull/439#discussion_r2641950569
########## tests/e2e/helm/selector-config-values.yaml: ########## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +operatorConfiguration: + spark-operator.properties: |+ + spark.kubernetes.operator.reconciler.selectors=foo=bar Review Comment: ack - updated the test case such that * Operator is configured with comma-separated key values * Validate resources is not being reconciled if - no label matches the given selector string - resource has only one matching label, but not all - resource has given label, but the value does not match * Resource is reconciled only when matching all required label selectors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
