Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6723#discussion_r32078070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalFunctions.scala
---
@@ -50,6 +60,15 @@ case class MakeDecimal(child: Expression, precision:
Int, scale: Int) extends Un
override def nullable: Boolean = child.nullable
override def toString: String = s"MakeDecimal($child,$precision,$scale)"
+ override def checkInputDataTypes(): TypeCheckResult = {
+ if (child.dataType == LongType) {
+ TypeCheckResult.TypeCheckSuccess
+ } else {
+ TypeCheckResult.TypeCheckFailure(
+ s"MakeDecimal only accept long type, not ${child.dataType}")
--- End diff --
actually can't we just define ExpectedInputTypes here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
