Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6723#discussion_r32085499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -68,6 +68,8 @@ case class WindowSpecDefinition(
override def children: Seq[Expression] = partitionSpec ++ orderSpec
+ override def checkInputDataTypes(): TypeCheckResult =
TypeCheckResult.TypeCheckSuccess
--- End diff --
This is fine. We only need to check the data types for those window
functions (for now, we only have HiveWindowFunction). WindowSpecDefinition and
WindowExpression are just containers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
