Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6723#discussion_r32080543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalFunctions.scala
---
@@ -28,6 +29,15 @@ case class UnscaledValue(child: Expression) extends
UnaryExpression {
override def nullable: Boolean = child.nullable
override def toString: String = s"UnscaledValue($child)"
+ override def checkInputDataTypes(): TypeCheckResult = {
+ if (child.dataType.isInstanceOf[DecimalType]) {
+ TypeCheckResult.TypeCheckSuccess
+ } else {
+ TypeCheckResult.TypeCheckFailure(
+ s"UnscaledValue only accept decimal type, not ${child.dataType}")
--- End diff --
`ExpectedInputTypes` not only define the type check behavior, but also type
cast. Do we need to do type cast for `UnscaledValue` and `MakeDecimal`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
