MonkeyCanCode commented on code in PR #53078:
URL: https://github.com/apache/spark/pull/53078#discussion_r2662222041
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala:
##########
@@ -265,6 +265,7 @@ object ResolvedIdentifier {
object FakeSystemCatalog extends CatalogPlugin {
override def initialize(name: String, options: CaseInsensitiveStringMap):
Unit = {}
override def name(): String = "system"
+ override def close(): Unit = {}
Review Comment:
This is now removed as this is default.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/CatalogManagerSuite.scala:
##########
@@ -127,6 +127,18 @@ class CatalogManagerSuite extends SparkFunSuite with
SQLHelper {
}
}
}
+
+ test("CatalogManager.close should close all closeable catalogs") {
+ val catalogManager = new CatalogManager(FakeV2SessionCatalog,
createSessionCatalog())
+ withSQLConf("spark.sql.catalog.dummy" -> classOf[DummyCatalog].getName,
Review Comment:
This is updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
