MonkeyCanCode commented on code in PR #53078:
URL: https://github.com/apache/spark/pull/53078#discussion_r2662230179
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala:
##########
@@ -110,6 +110,10 @@ private[sql] class SessionState(
def catalogManager: CatalogManager = analyzer.catalogManager
+ override def close(): Unit = {
Review Comment:
Good catch on this one as `ArtifactManager` is also closable and should be
close as well (from the heap analysis, this was not taking up much heap as
primary non-released were from session state). i had added this one as well.
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala:
##########
@@ -110,6 +110,10 @@ private[sql] class SessionState(
def catalogManager: CatalogManager = analyzer.catalogManager
+ override def close(): Unit = {
Review Comment:
Good catch on this one as `ArtifactManager` is also closable and should be
close as well (from the heap analysis, this was not taking up much heap as
primary non-released were from session state). i had added this one as well.
Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
