zikangh commented on code in PR #53828:
URL: https://github.com/apache/spark/pull/53828#discussion_r2700349143
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufFunctionsSuite.scala:
##########
@@ -2279,4 +2306,222 @@ class ProtobufFunctionsSuite extends QueryTest with
SharedSparkSession with Prot
assert(expectedDf.schema === fromProtoDf.schema)
checkAnswer(fromProtoDf, expectedDf)
}
+
+ test("SPARK-55062: roundtrip - proto2 extension basic types") {
Review Comment:
What do you think about adding test cases for these edge cases?
1. extension field name collision with regular fields
2. schema evolution: read old data without extensions using new schema with
extensions.
3. map extensions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
