dichlorodiphen commented on code in PR #53828:
URL: https://github.com/apache/spark/pull/53828#discussion_r2710625349
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufFunctionsSuite.scala:
##########
@@ -2279,4 +2306,222 @@ class ProtobufFunctionsSuite extends QueryTest with
SharedSparkSession with Prot
assert(expectedDf.schema === fromProtoDf.schema)
checkAnswer(fromProtoDf, expectedDf)
}
+
+ test("SPARK-55062: roundtrip - proto2 extension basic types") {
Review Comment:
Good call, the original unit tests were in hindsight pretty lacking. I've
added the above plus a few more. For #3, however, I believe the Protobuf
grammar doesn't allow map fields in extensions (`protoc` will error), so there
shouldn't be a need for a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
