dichlorodiphen commented on code in PR #53828:
URL: https://github.com/apache/spark/pull/53828#discussion_r2710630271
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/ProtobufDataToCatalyst.scala:
##########
@@ -99,7 +99,7 @@ private[sql] case class ProtobufDataToCatalyst(
override def nullSafeEval(input: Any): Any = {
val binary = input.asInstanceOf[Array[Byte]]
try {
- result = DynamicMessage.parseFrom(messageDescriptor, binary)
+ result = DynamicMessage.parseFrom(messageDescriptor, binary,
extensionRegistry)
Review Comment:
A pretty flagrant error--I must have dropped this when reapplying changes
from my other repo. I also realized as a result that the original tests were
not explicitly checking for the added fields (roundtrip was working because the
fields were being dropped), so I've added in those assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
