zhengruifeng commented on code in PR #54044: URL: https://github.com/apache/spark/pull/54044#discussion_r2785323136
########## python/pyspark/pandas/tests/computation/test_idxmax_idxmin.py: ########## @@ -0,0 +1,151 @@ +# Review Comment: new test file should be added in `modules.py`, otherwise it doesn't take effect. And we may also want to test it in connect mode, current approach is to add a parity test in `python/pyspark/pandas/tests/connect/computation` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
