gaogaotiantian commented on PR #54044: URL: https://github.com/apache/spark/pull/54044#issuecomment-3917542915
> @gaogaotiantian In pandas, test_index.py would imply testing on the index/row labels rather than these methods. I don't anticipate adding more than idxmax and idxmin to this test, what do you think about test_idxmaxmin or something more concise? Yes, `test_index` should indicate that we are testing `index` in general, and I was hoping that we've already tested `index` somewhere in our code base. I brought it up because we have a `test_index` in `pyspark.pandas.test.series` which tested `index` in general - including `idxmax` and `idxmin`. Maybe I had the wrong idea about what `idxmax` and `idxmin` do for a dataframe and they should be tested in a separate file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
