ueshin commented on code in PR #54044:
URL: https://github.com/apache/spark/pull/54044#discussion_r2824167074
##########
python/pyspark/pandas/frame.py:
##########
@@ -9081,12 +9081,21 @@ def combine_first(self, other: "DataFrame") ->
"DataFrame":
)
return DataFrame(internal)
- # TODO(SPARK-46163): add 'filter_func' and 'errors' parameter
- def update(self, other: "DataFrame", join: str = "left", overwrite: bool =
True) -> None:
+ def update(
Review Comment:
oh, wait. why does this include the change for `update`? This seems not
related to the `axis`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
