viirya commented on code in PR #54280:
URL: https://github.com/apache/spark/pull/54280#discussion_r2800124667
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileWriters.scala:
##########
@@ -131,7 +131,20 @@ abstract class EventLogFileWriter(
}
protected def closeWriter(): Unit = {
+ // 1. Flush first to check the errors
+ writer.foreach(_.flush())
+ if (writer.exists(_.checkError())) {
+ logWarning("Spark detects errors while flushing event logs.")
Review Comment:
If it is an error, I wonder why not use logError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
