gaogaotiantian commented on code in PR #54009:
URL: https://github.com/apache/spark/pull/54009#discussion_r2819482932
##########
python/pyspark/pandas/frame.py:
##########
@@ -11361,9 +11361,13 @@ def _result_aggregated(
# dtype: bool
return first_series(DataFrame(internal))
- # TODO(SPARK-46167): add axis, pct, na_option parameter
+ # TODO(SPARK-46167): add pct, na_option parameter
def rank(
- self, method: str = "average", ascending: bool = True, numeric_only:
bool = False
+ self,
+ method: str = "average",
+ ascending: bool = True,
+ numeric_only: bool = False,
+ axis: Axis = 0,
Review Comment:
Personally, I think it's not great for us to have a different positional
parameter order than pandas in long term. So maybe it's nicer to hurt the user
once instead of twice? But maybe backward compatibility is a huge thing here
and we had to preserve the non-ideal usage. In that case we probably need a
former proposal about how to move towards keyword-only arguments. Hyukjin is on
vacation this week so we probably need to wait a few days to have a final
decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
