devin-petersohn commented on code in PR #54009:
URL: https://github.com/apache/spark/pull/54009#discussion_r2824670931
##########
python/pyspark/pandas/frame.py:
##########
@@ -11361,9 +11361,13 @@ def _result_aggregated(
# dtype: bool
return first_series(DataFrame(internal))
- # TODO(SPARK-46167): add axis, pct, na_option parameter
+ # TODO(SPARK-46167): add pct, na_option parameter
def rank(
- self, method: str = "average", ascending: bool = True, numeric_only:
bool = False
+ self,
+ method: str = "average",
+ ascending: bool = True,
+ numeric_only: bool = False,
+ axis: Axis = 0,
Review Comment:
In my opinion, it's more important to be backward compatible with Pyspark
than it is to have perfect argument order fidelity with pandas. I would argue
that this would not be the right PR to introduce keyword-only arguments since
that's a different change altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
