holdenk commented on code in PR #54009:
URL: https://github.com/apache/spark/pull/54009#discussion_r2824777615
##########
python/pyspark/pandas/frame.py:
##########
@@ -11361,9 +11361,13 @@ def _result_aggregated(
# dtype: bool
return first_series(DataFrame(internal))
- # TODO(SPARK-46167): add axis, pct, na_option parameter
+ # TODO(SPARK-46167): add pct, na_option parameter
def rank(
- self, method: str = "average", ascending: bool = True, numeric_only:
bool = False
+ self,
+ method: str = "average",
+ ascending: bool = True,
+ numeric_only: bool = False,
+ axis: Axis = 0,
Review Comment:
I'm also broadly against switching to kwargs only, that'll could be annoying
for folks doing an upgrade. In my mind the question is do we expect more people
to be upgrading between PySpark on pandas v 4.2 and v4.3 w/ positional args OR
jumping over from pandas to PySpark. Also given the type mismatch hopefully
someone in the latter case will get a clear enough error message / mypy error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
