peter-toth commented on code in PR #54330: URL: https://github.com/apache/spark/pull/54330#discussion_r2879761566
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/GroupPartitionsExec.scala: ########## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +package org.apache.spark.sql.execution.datasources.v2 + +import scala.collection.mutable.ArrayBuffer + +import org.apache.spark.{Partition, SparkException} +import org.apache.spark.rdd.{CoalescedRDD, PartitionCoalescer, PartitionGroup, RDD} +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.plans.physical.{KeyedPartitioning, Partitioning} +import org.apache.spark.sql.catalyst.util.InternalRowComparableWrapper +import org.apache.spark.sql.connector.catalog.functions.Reducer +import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode} +import org.apache.spark.sql.types.DataType + +/** + * Physical operator that groups input partitions by their partition keys. + * + * This operator is used to coalesce partitions from bucketed/partitioned data sources + * where multiple input partitions share the same partition key. It's commonly used in + * storage-partitioned joins to align partitions from different sides of the join. + * + * @param child The child plan providing bucketed/partitioned input + * @param joinKeyPositions Optional projection to select a subset of the partitioning key + * for join compatibility (e.g., when join keys are a subset of + * partition keys) + * @param commonPartitionKeys Optional sequence of expected partition key values and their Review Comment: Ineed, fixed the docs and renamed the argument in https://github.com/apache/spark/pull/54330/commits/490f78279757187df8a83d392fc649801c5d02a2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
