peter-toth commented on PR #54330: URL: https://github.com/apache/spark/pull/54330#issuecomment-3992842846
> Also can we add more tests: > > * Empty grouped partitions: Plan that yields groupedPartitions.isEmpty (ie, partitioned table but no partition values inserted) > * Runtime filtering + KeyedPartitioning: Keyed scan with runtime filtering and Option[InputPartition] (including None for filtered-out keys); check result correctness and that no partition is read for filtered keys. > * OrderedDistribution: Require ordering on a keyed scan and assert that a single GroupPartitionsExec is inserted with the expected keys. > * Multi table joins (looks like there's already tests, but maybe we can check the plan shape for the GroupPartitionExec) Thanks @szehon-ho for taking a look. Let me add some more tests tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
