peter-toth commented on code in PR #54330:
URL: https://github.com/apache/spark/pull/54330#discussion_r2879768027
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -670,75 +657,57 @@ case class EnsureRequirements(
joinType == LeftAnti || joinType == LeftOuter
}
- // Populate the common partition information down to the scan nodes
- private def populateCommonPartitionInfo(
+ /**
+ * Unwraps a GroupPartitionsExec to get the underlying child plan.
+ */
+ private def unwrapGroupPartitions(plan: SparkPlan): SparkPlan = plan match {
+ case g: GroupPartitionsExec => g.child
+ case other => other
+ }
+
+ /**
+ * Applies or updates GroupPartitionsExec with the given parameters.
+ */
+ private def applyGroupPartitions(
plan: SparkPlan,
- values: Seq[(InternalRow, Int)],
joinKeyPositions: Option[Seq[Int]],
+ mergedPartitionKeys: Seq[(InternalRow, Int)],
reducers: Option[Seq[Option[Reducer[_, _]]]],
applyPartialClustering: Boolean,
- replicatePartitions: Boolean): SparkPlan = plan match {
- case scan: BatchScanExec =>
- val newScan = scan.copy(
- spjParams = scan.spjParams.copy(
- commonPartitionValues = Some(values),
+ replicatePartitions: Boolean): SparkPlan = {
+ plan match {
+ case g: GroupPartitionsExec =>
+ g.copy(
Review Comment:
It is always preferred to preserve tags, fixed in
https://github.com/apache/spark/pull/54330/commits/490f78279757187df8a83d392fc649801c5d02a2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
