XdithyX commented on code in PR #55782:
URL: https://github.com/apache/spark/pull/55782#discussion_r3267539820
##########
sql/api/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -295,6 +295,56 @@ private[sql] object QueryParsingErrors extends
DataTypeErrorsBase {
ctx)
}
+ def unsupportedRowFormatLinesTerminatedByError(
+ value: String,
+ ctx: ParserRuleContext): Throwable = {
+ new ParseException(
+ errorClass =
"INVALID_SQL_SYNTAX.UNSUPPORTED_ROW_FORMAT_LINES_TERMINATED_BY",
+ messageParameters = Map("value" -> value),
+ ctx)
+ }
+
+ def invalidTableFunctionTableArgumentPartitioningError(
+ clause: String,
+ ctx: ParserRuleContext): Throwable = {
+ new ParseException(
+ errorClass =
"INVALID_SQL_SYNTAX.INVALID_TABLE_FUNCTION_TABLE_ARGUMENT_PARTITIONING",
+ messageParameters = Map("clause" -> clause),
+ ctx)
+ }
+
+ def invalidTableFunctionTableArgumentWithSinglePartitionError(
Review Comment:
@stanyao Thanks for pointing this out. I added PlanParserSuite coverage for
the reachable table function parser error path, including the ORDER BY variant.
I also removed the two newly added table-function error classes that were
not reachable from SQL parsing because the grammar rejects those forms earlier
with PARSE_SYNTAX_ERROR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
