stanyao commented on PR #55782:
URL: https://github.com/apache/spark/pull/55782#issuecomment-4461293680
The goal of this JIRA item is to deprecate the usage of
"_LEGACY_ERROR_TEMP_0064" in TABLESAMPLE code path and likely other code paths
that depend on ParserUtils.scala. For example, in test("SPARK-55978:
TABLESAMPLE SYSTEM - fraction out of range") in PlanParserSuite.scala. Starting
from that call site, there is a call chain of -> AnalysisTest.scala ->
AbstractSqlParser.scala -> AstBuilder.scala -> validate() function in
ParserUtils.scala that is shared by both the existing Bernoulli sampling and
the new System sampling. Fixing this will need code changes to 10 call sites
and 20 test cases. That is a super set of TABLESAMPLE. Fixing them all at once
is the best approach. I don't think your PR currently covers the full fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
