sarutak commented on code in PR #56186: URL: https://github.com/apache/spark/pull/56186#discussion_r3317840081
########## dev/make-distribution.sh: ########## @@ -294,7 +294,11 @@ mkdir "$DISTDIR/conf" cp "$SPARK_HOME"/conf/*.template "$DISTDIR/conf" cp "$SPARK_HOME/README.md" "$DISTDIR" cp -r "$SPARK_HOME/bin" "$DISTDIR" -cp -r "$SPARK_HOME/python" "$DISTDIR" +if command -v git && command -v cpio && git rev-parse --git-dir 2>/dev/null; then Review Comment: To keep the console clean, how about redirecting the stdout/stderr of `command -v` to `/dev/null`? ########## dev/make-distribution.sh: ########## @@ -294,7 +294,11 @@ mkdir "$DISTDIR/conf" cp "$SPARK_HOME"/conf/*.template "$DISTDIR/conf" cp "$SPARK_HOME/README.md" "$DISTDIR" cp -r "$SPARK_HOME/bin" "$DISTDIR" -cp -r "$SPARK_HOME/python" "$DISTDIR" +if command -v git && command -v cpio && git rev-parse --git-dir 2>/dev/null; then + git ls-files -z "$SPARK_HOME/python" | cpio -pdm "$DISTDIR" Review Comment: I'm concerned about whether cpio behaves the same way in GNU and BSD. Did you confirm this script works on macOS and Linux? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
