pan3793 commented on code in PR #56186:
URL: https://github.com/apache/spark/pull/56186#discussion_r3321835203
##########
dev/make-distribution.sh:
##########
@@ -294,7 +294,11 @@ mkdir "$DISTDIR/conf"
cp "$SPARK_HOME"/conf/*.template "$DISTDIR/conf"
cp "$SPARK_HOME/README.md" "$DISTDIR"
cp -r "$SPARK_HOME/bin" "$DISTDIR"
-cp -r "$SPARK_HOME/python" "$DISTDIR"
+if command -v git && command -v cpio && git rev-parse --git-dir 2>/dev/null;
then
+ git ls-files -z "$SPARK_HOME/python" | cpio -pdm "$DISTDIR"
Review Comment:
@sarutak thanks for checking, yes, `-0` should be used
```
Operation modifiers valid in copy-out and copy-pass modes:
-0, --null Filenames in the list are delimited by null
```
but I think `cd` is not required as it runs `cd "$SPARK_HOME"` in lien 169,
I tested it by running the `make-distribution.sh` under `$SPARK_HOME/common`,
it works fine, am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
