pan3793 commented on code in PR #56186: URL: https://github.com/apache/spark/pull/56186#discussion_r3318049761
########## dev/make-distribution.sh: ########## @@ -294,7 +294,11 @@ mkdir "$DISTDIR/conf" cp "$SPARK_HOME"/conf/*.template "$DISTDIR/conf" cp "$SPARK_HOME/README.md" "$DISTDIR" cp -r "$SPARK_HOME/bin" "$DISTDIR" -cp -r "$SPARK_HOME/python" "$DISTDIR" +if command -v git && command -v cpio && git rev-parse --git-dir 2>/dev/null; then + git ls-files -z "$SPARK_HOME/python" | cpio -pdm "$DISTDIR" Review Comment: my testing (also confirmed by asking LLM) shows the BSD `cpio` has different behavior when involving symlinks, but I think it does not affect the `make-distribution.sh` case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
