j1wonpark opened a new pull request, #56341: URL: https://github.com/apache/spark/pull/56341
### What changes were proposed in this pull request? Implement the `SparkConnectStatement` accessors that previously threw `SQLFeatureNotSupportedException` (`setFetchSize`/`getFetchSize`, `setFetchDirection`/`getFetchDirection`, `getResultSetType`, `setQueryTimeout`/`getQueryTimeout`), fix `getMoreResults` (which threw, breaking JDBC result-drain loops), and implement the `createStatement` type/concurrency overloads on `SparkConnectConnection`. Follow-up to SPARK-54108 / SPARK-54014. Fetch size / query timeout are stored as hints (Spark Connect is forward-only and server-paginated); `createStatement` accepts forward-only / scroll-insensitive and rejects updatable / scroll-sensitive, mirroring the Spark Thrift Server's Hive JDBC policy. See SPARK-57274 for details. ### Why are the changes needed? JDBC client tools (e.g. DataGrip) call these methods around every query, so the throws abort the query path. `getMoreResults` throwing in particular makes the standard drain loop `while (getMoreResults() || getUpdateCount() != -1)` error out or spin forever; DataGrip hangs on a result-less command such as `USE <db>`. ### Does this PR introduce _any_ user-facing change? Yes, in the unreleased master only: methods that previously threw `SQLFeatureNotSupportedException` are now implemented. No existing behavior is removed. ### How was this patch tested? New cases in `SparkConnectStatementSuite`: accessor defaults/validation, drain-loop termination, and the typed `createStatement` overloads. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
