pan3793 commented on code in PR #56341:
URL: https://github.com/apache/spark/pull/56341#discussion_r3361719672
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectConnection.scala:
##########
@@ -98,8 +98,11 @@ class SparkConnectConnection(val url: String, val info:
Properties) extends Conn
override def createStatement(
resultSetType: Int,
resultSetConcurrency: Int,
- resultSetHoldability: Int): Statement =
- throw new SQLFeatureNotSupportedException
+ resultSetHoldability: Int): Statement = {
+ // holdability is ignored
Review Comment:
do we really need to override this method? the javadoc clearly states that
`SQLFeatureNotSupportedException` may be thrown – if the JDBC driver does not
support this method or this method is not supported for the specified result
set type, result set holdability and result set concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
