pan3793 commented on code in PR #56341:
URL: https://github.com/apache/spark/pull/56341#discussion_r3371228633
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectConnection.scala:
##########
@@ -128,8 +128,26 @@ class SparkConnectConnection(val url: String, val info:
Properties) extends Conn
throw new SQLFeatureNotSupportedException
override def createStatement(
- resultSetType: Int, resultSetConcurrency: Int): Statement =
- throw new SQLFeatureNotSupportedException
Review Comment:
the change for this method seems not necessary too, it works well both
with/without this method change
I checked with DataGrip 2026.1.3 (Build #DB-261.24374.56, built on May 4,
2026)
<img width="1695" height="1024" alt="Image"
src="https://github.com/user-attachments/assets/37e893fa-4e40-4a18-a118-ae5bbdfb0110";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
