j1wonpark commented on PR #56341: URL: https://github.com/apache/spark/pull/56341#issuecomment-4656517954
You're right, the `createStatement(type, concurrency)` override isn't needed — I confirmed it makes no difference for DataGrip. Reverted it to throw `SQLFeatureNotSupportedException` and removed the now-unused `checkSupportedResultSet` helper, `stringifyResultSetConcurrency`, and the related test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
