yadavay-amzn commented on PR #56437: URL: https://github.com/apache/spark/pull/56437#issuecomment-4675180473
Thanks for pinging me @dongjoon-hyun. Yes, `spark.sql.hive.thriftServer.http.sniHostCheckEnabled` should get `NOT_APPLICABLE` since it's a transport-layer toggle for Jetty's SNI host check on incoming HTTPS connections to ThriftHttpCLIService and has no effect on SQL view / UDF / procedure semantics. Same shape as `useHashAggregateExec` here. I can either fold the fix into this PR or send it as a small separate PR, whichever is preferred. The sibling `spark.ui.jetty.sniHostCheckEnabled` (from SPARK-56528) has the same reasoning if it's also worth cleaning up while we're at it. cc @pan3793 to keep me honest on my assessment above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
