cloud-fan commented on PR #56437:
URL: https://github.com/apache/spark/pull/56437#issuecomment-4675551864
@gaogaotiantian The new job never runs on apache/spark, so it doesn't add
anything to the ASF concurrent task limit. It is gated by `github.repository !=
'apache/spark'` at the job level, and Spark PR CI runs on the contributor's
fork (via the `push` trigger of `build_main.yml`), consuming the contributor's
own GitHub Actions quota. On apache/spark itself (post-merge and daily
scheduled builds) the job is skipped at the scheduler level and never occupies
a runner.
I also considered `dev/run-tests.py`, but it is executed by every test job
in the build matrix, so the check would run (and on violation, fail) in a dozen
jobs per build, while a dedicated job runs it exactly once on a bare runner in
~10 seconds. It also gives PR authors a clearly-named failing check ("Config
binding policy exceptions check") right in the PR checks UI, instead of a
failure buried in test logs.
It's verified end to end in this PR: a temp commit adding an entry made the
job fail with the guidance message in ~10s
(https://github.com/cloud-fan/spark/actions/runs/27302316185), and the
subsequent commits that shrink the file pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
