pan3793 commented on code in PR #56437:
URL: https://github.com/apache/spark/pull/56437#discussion_r3392881130
##########
.github/workflows/build_and_test.yml:
##########
@@ -1038,6 +1038,56 @@ jobs:
if: inputs.branch != 'branch-3.5'
run: ./dev/check-protos.py
+ # The config binding policy exceptions file lists pre-existing configs that
were created before
+ # the binding policy was introduced. It must never grow: new configs must
declare a binding
+ # policy via .withBindingPolicy() instead of being added to the exceptions
file. This job fails
Review Comment:
can you add similar words to `SparkConfigBindingPolicySuite` or
`configs-without-binding-policy-exceptions`?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3250,6 +3250,7 @@ object SQLConf {
"This enables sink evolution capability where sinks can be changed
while maintaining " +
"a historical record of all sinks used in the checkpoint.")
.version("4.1.0")
Review Comment:
wrong version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
