dongjoon-hyun commented on code in PR #707: URL: https://github.com/apache/spark-kubernetes-operator/pull/707#discussion_r3415028686
########## docs/config_properties.md: ########## @@ -10,9 +10,10 @@ | spark.kubernetes.operator.api.secondaryResourceCreateMaxAttempts | Long | 3 | false | Maximal number of retry attempts of requesting secondary resource for Spark application. This would be performed on top of k8s client spark.kubernetes.operator.retry.maxAttempts to overcome potential conflicting reconcile on the same SparkApplication, as well as API server errors (408/500/502/503/504) and network-level timeouts. Exponential backoff with jitter is applied before retrying on 409 (Conflict) and 429 (Too Many Requests) responses. Other retryable errors are retried immediately. This should be positive number. | | spark.kubernetes.operator.api.secondaryResourceCreateMaxBackoffMillis | Long | 40000 | false | Maximum backoff (in milliseconds) between retries when creating secondary resources for Spark application. | | spark.kubernetes.operator.api.statusPatchMaxAttempts | Long | 3 | false | Maximal number of retry attempts of requests to k8s server for resource status update. This would be performed on top of k8s client spark.kubernetes.operator.retry.maxAttempts to overcome potential conflicting update on the same SparkApplication. This should be positive number. | - | spark.kubernetes.operator.dynamicConfig.enabled | Boolean | false | false | When enabled, operator would use config map as source of truth for config property override. The config map need to be created in spark.kubernetes.operator.namespace, and labeled with operator name. | + | spark.kubernetes.operator.dynamicConfig.enabled | Boolean | false | false | When enabled, operator periodically reloads property overrides from a properties file mounted from a ConfigMap. The file path is controlled by spark.kubernetes.operator.dynamicConfig.filePath. | + | spark.kubernetes.operator.dynamicConfig.filePath | String | /opt/spark-operator/dynamic-conf/spark-operator-dynamic.properties | false | Path of the properties file holding dynamic configuration overrides. Typically populated by mounting a ConfigMap as a volume. | | spark.kubernetes.operator.dynamicConfig.reconcilerParallelism | Integer | 1 | false | Parallelism for dynamic config reconciler. Unbounded pool would be used if set to non-positive number. | - | spark.kubernetes.operator.dynamicConfig.selector | String | app.kubernetes.io/name=spark-kubernetes-operator,app.kubernetes.io/component=operator-dynamic-config-overrides | false | The selector str applied to dynamic config map. | Review Comment: BTW, @csviri . This is intrusive. In general, Apache Spark community tries to keep old features as legacy alternatives. Please recover the old feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
