dongjoon-hyun commented on code in PR #707:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/707#discussion_r3424363181
##########
spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/HealthProbeTest.java:
##########
@@ -86,48 +78,12 @@ public boolean isStarted() {
}
};
- RuntimeInfo runtimeInfo2 =
- new RuntimeInfo(
- new Operator(overrider ->
overrider.withKubernetesClient(kubernetesClient))) {
- @Override
- public boolean isStarted() {
- return isRunning2.get();
- }
-
- @Override
- public Map<String, Map<String,
InformerWrappingEventSourceHealthIndicator>>
- unhealthyInformerWrappingEventSourceHealthIndicator() {
- return unhealthyEventSources2;
- }
- };
-
when(operator.getRuntimeInfo()).thenReturn(runtimeInfo);
- when(sparkConfMonitor.getRuntimeInfo()).thenReturn(runtimeInfo2);
- }
-
- @Test
- void testHealthProbeWithInformerHealthWithMultiOperators() {
Review Comment:
May I ask if this is inevitable removal of irrelevant `HealthProbe` test
coverage, @csviri ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
