loftiest commented on PR #56498: URL: https://github.com/apache/spark/pull/56498#issuecomment-4751874548
> There is one very important consideration here - missing `CollationTypeCoercion` registration for the new expression. > Another important consideration is `ResolverGuard` allowlist entry. @uros-b Thanks for catching both the missing `CollationTypeCoercion` and `ResolverGuard` registrations! I've added `StringInstrWithOccurrence` to both match sites in `CollationTypeCoercion.scala` and to the allowlist in `ResolverGuard.scala`. I also updated the golden files and added a Connect test accordingly. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
