cloud-fan commented on code in PR #56498:
URL: https://github.com/apache/spark/pull/56498#discussion_r3469951933
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1246,6 +1246,114 @@ public int indexOf(UTF8String v, int start) {
return -1;
}
+ /**
+ * Finds the {@code occurrence}-th occurrence of {@code pattern} in this
string,
+ * starting the search at the specified position.
+ * When {@code start} is positive, the search proceeds forward from the
+ * {@code start}-th character (1‑based). When {@code start} is negative, the
Review Comment:
`1-based` here uses a U+2011 non-breaking hyphen, while `@param start` just
below uses a plain ASCII `-`. This is the same character you fixed last round
(r3430661449); the doc rewrite reintroduced it. It violates the
ASCII-in-comments convention (scalastyle won't catch it since this is `.java`,
not `.scala`).
```suggestion
* {@code start}-th character (1-based). When {@code start} is negative,
the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
