uros-b commented on code in PR #56498: URL: https://github.com/apache/spark/pull/56498#discussion_r3472463867
########## sql/core/src/test/resources/sql-tests/inputs/collations-string-functions.sql: ########## @@ -74,6 +74,13 @@ select instr(utf8_binary collate utf8_lcase, utf8_lcase collate utf8_lcase) from select instr(utf8_binary collate unicode_ai, utf8_lcase collate unicode_ai) from t1; select instr(utf8_binary, 'a'), instr(utf8_lcase, 'a') from t1; select instr(utf8_binary, 'AaAA' collate utf8_lcase), instr(utf8_lcase, 'AAa' collate utf8_binary) from t1; +select instr(utf8_binary, utf8_lcase, 1) from t1; +select instr(utf8_lcase, 'a', 1) from t1; +select instr(utf8_binary collate utf8_lcase, utf8_lcase collate utf8_lcase, -1) from t1; +select instr(s, utf8_binary, 1, 2) from t1; +select instr(utf8_binary, utf8_lcase collate utf8_binary, -1, 2) from t1; +select instr(utf8_binary collate unicode_ai, utf8_lcase collate unicode_ai, 2, 1) from t1; +select instr(utf8_binary, 'a', 0, 1) from t1; Review Comment: Nit: these are all collation-specific golden tests. Can we please add a few appropriate test cases to a general string-functions SQL test file, to further improve discoverability and coverage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
