shrirangmhalgi commented on PR #56634: URL: https://github.com/apache/spark/pull/56634#issuecomment-4760023473
Thanks @MaxGekk for the thorough review. Addressed all the points in latest commit. - Moved JSON time inference inside `if (options.inferTimestamp)` block so it requires the same temporal opt-in as timestamp (consistent with SPARK-32130 rationale). - Fixed the weak CSV assertion to pin the actual type (`TimestampType`) - Added negative cases in JSON (date/timestamp strings shouldn't become TimeType) - **Cross-row merge test:** Added compatibleType coverage in `CSVInferSchemaSuite` (TimeType + non-time → StringType, TimeType + Date → StringType). Ill file a separate JIRA for `XmlInferSchema` once this is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
