shrirangmhalgi commented on PR #56634: URL: https://github.com/apache/spark/pull/56634#issuecomment-4761043195
Thanks @uros-b for the review! Addressed all the points in latest commit: - Switched to `TimeType.DEFAULT_PRECISION` to avoid hardcoding micros - Restored the `NTZ` comment (moved it to the new nesting level) - Replaced the JSON merge test with proper `JsonInferSchema.compatibleType` assertions (Time+Time, Time+String, Time+Date, Time+Null) - Added end-to-end `spark.read.csv` and `spark.read.json` inference round-trip tests in `CSVSuite` / `JsonSuite` Good callout on the precision. Agreed we should keep it flexible for when nano support lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
