uros-b commented on code in PR #56388: URL: https://github.com/apache/spark/pull/56388#discussion_r3448636046
########## sql/core/src/test/resources/sql-tests/inputs/array.sql: ########## @@ -95,6 +95,7 @@ from primitive_arrays; select element_at(array(1, 2, 3), 5); select element_at(array(1, 2, 3), -5); select element_at(array(1, 2, 3), 0); +select element_at(array(1, 2, 3), -2147483648); Review Comment: Minor nit: These inputs are all literals, so it gets constant-folded during optimization and evaluated through the interpreted path. We never run whole-stage codegen end-to-end. It would be nice to have codegen path coverage in end-to-end SQL tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
