MaxGekk commented on PR #56388: URL: https://github.com/apache/spark/pull/56388#issuecomment-4763288970
Nice catch overall — the fix itself looks solid. One test-coverage nit: The newly added SQL golden cases use literal indices (), so they get constant-folded during optimization and won’t exercise whole-stage codegen end-to-end. Since this PR also changes the codegen path in , could we add at least one non-literal index case (e.g., index from a column/expression) so runtime codegen is covered too? That would validate the exact path this patch updates in generated code as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
