jiwen624 commented on PR #56388: URL: https://github.com/apache/spark/pull/56388#issuecomment-4764995970
New golden cases with non-literal index are added to exercise the codegen path end-to-end, though the golden files don't record the physical plan. Also, the UT case in [CollectionExpressionsSuite](https://github.com/apache/spark/pull/56388/changes#diff-355f870fd2838e8777b3f858468f3b120d5869becd828c377955a893ba0af45aR3328) should also evaluate the codegen path from the unit test perspective (by `checkEvaluation`, etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
